Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shardscanner workflow tests to the shardscanner package #5981

Merged
merged 1 commit into from
May 7, 2024
Merged

Move shardscanner workflow tests to the shardscanner package #5981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions service/worker/scanner/shardscanner/scanner_workflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,16 @@ import (
"github.com/uber/cadence/common/reconciliation/invariant"
)

type workflowsSuite struct {
type scannerWorkflowsSuite struct {
suite.Suite
testsuite.WorkflowTestSuite
}

func TestScannerWorkflowSuite(t *testing.T) {
suite.Run(t, new(workflowsSuite))
suite.Run(t, new(scannerWorkflowsSuite))
}

func (s *workflowsSuite) TestGetBatchIndices() {
func (s *scannerWorkflowsSuite) TestGetBatchIndices() {
testCases := []struct {
batchSize int
concurrency int
Expand Down Expand Up @@ -101,7 +101,7 @@ func (s *workflowsSuite) TestGetBatchIndices() {
}
}

func (s *workflowsSuite) TestGetShardBatches() {
func (s *scannerWorkflowsSuite) TestGetShardBatches() {
var shards []int
for i := 5; i < 50; i += 2 {
shards = append(shards, i)
Expand All @@ -113,7 +113,7 @@ func (s *workflowsSuite) TestGetShardBatches() {
}, batches)
}

func (s *workflowsSuite) TestFlattenShards() {
func (s *scannerWorkflowsSuite) TestFlattenShards() {
testCases := []struct {
input Shards
expectedList []int
Expand Down Expand Up @@ -160,7 +160,7 @@ func (s *workflowsSuite) TestFlattenShards() {
}
}

func (s *workflowsSuite) TestValidateShards() {
func (s *scannerWorkflowsSuite) TestValidateShards() {
testCases := []struct {
shards Shards
expectErr bool
Expand Down
50 changes: 0 additions & 50 deletions service/worker/scanner/shardscanner/shardscannertest/workflow.go
View file
Open in desktop

This file was deleted.

Loading
Loading