Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shardscanner workflow tests to the shardscanner package #5981

Merged
merged 1 commit into from
May 7, 2024

Conversation

natemort
Copy link
Member

@natemort natemort commented May 7, 2024

What changed?

  • Move existing tests for the shardscanner workflows to be in the shardscanner package.

Why?

  • Improve code coverage metrics

How did you test it?

  • Unit tests

Potential risks

Release notes

Documentation Changes

This ensures they get included in the code coverage metrics.
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.08%. Comparing base (2ac145f) to head (e06d148).
Report is 1 commits behind head on master.

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac145f...e06d148. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5495-ff35-464f-adfd-e78b0d8345c5

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.1%) to 68.26%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/task/transfer_standby_task_executor.go 2 87.65%
service/history/shard/context.go 2 68.91%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/task/transfer_active_task_executor.go 2 72.9%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/historyManager.go 2 66.67%
service/history/task/fetcher.go 3 85.57%
service/history/execution/mutable_state_task_refresher.go 32 56.65%
Totals Coverage Status
Change from base Build 018f5467-b337-442d-bcf0-8ad761c213c7: 0.1%
Covered Lines: 100260
Relevant Lines: 146880

💛 - Coveralls

@natemort natemort merged commit 17a7ba7 into cadence-workflow:master May 7, 2024
20 checks passed
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 7, 2024
…-workflow#5981)

This ensures they get included in the code coverage metrics.
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 7, 2024
…-workflow#5981)

This ensures they get included in the code coverage metrics.
agautam478 pushed a commit to agautam478/cadence that referenced this pull request May 8, 2024
…-workflow#5981)

This ensures they get included in the code coverage metrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants