fileserver: browse: do not encode the paths in breadcrumbs and page title #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SlavikCA would you be able to build from this branch to confirm the fix? Thanks! |
francislavoie
added
bug 🐞
mohammed90
changed the title
|
@SlavikCA Can you confirm this fixes it for you? |
|
Thank you very much! Yes, just tested and both page title and breadcrumbs looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breadcrumbs use the
.Namefield as the visual item while.Pathis the data-oriented item. Earlier implementation used the URL path as-is, which could have been in escaped format. This PR un-escapes the URL path to use as for the.Name.Fixes #4409