Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.6 regression: file_browser displays path unencoded #4409

Closed
SlavikCA opened this issue Nov 9, 2021 · 2 comments · Fixed by #4410
Closed

2.4.6 regression: file_browser displays path unencoded #4409

SlavikCA opened this issue Nov 9, 2021 · 2 comments · Fixed by #4410
Assignees
Labels
bug 🐞 Something isn't working

Comments

@SlavikCA
Copy link
Contributor

SlavikCA commented Nov 9, 2021

Use case:
I'm using Caddy to publish school lesson's videos & images via file_server. Here is config:

:80
bind 0.0.0.0

root * /var/www/html
file_server browse {
  hide "#snapshot" "@eaDir" *.db
}

In version 2.4.5 the name of current folder was displayed correctly on top of the page (the breadcrumb).

Bug:
However, in version 2.4.6 it is displayed unencoded. I suspect it caused by security patch and is probably needed. But can the path be correctly encoded and displayed in the UI?

The URL's are changed, too.

The page <title> is unencoded, too

Here are 2 screenshots of 2.4.5 vs 2.4.6:

Space in the name of the folder:

Space

Russian characters:

RussianChars

@francislavoie
Copy link
Member

I think this was caused by 33c70f4 /cc @mohammed90

@mholt mholt added the bug 🐞 Something isn't working label Nov 9, 2021
@mohammed90
Copy link
Member

Thanks for the report! Looking at it 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants