improve user feedback when interacting with moderation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblgh
commented
Jun 4, 2020
src/cabal-details.js
Outdated
Comment on lines
676
to
693
| const promises = [this.moderation.getAdmins(), this.moderation.getMods()] | ||
| // get all moderation actions issued by our current mods & admins | ||
| Promise.all(promises).then(results => { | ||
| const keys = results[0].concat(results[1]) | ||
| keys.forEach(key => { | ||
| const write = (row, enc, next) => { | ||
| if (!row) return | ||
| const name = this.users[key].name || key.slice(0, 8) | ||
| const target = this.users[row.content.id].name || row.content.id.slice(0, 8) | ||
| const action = row.type.split("/")[1] | ||
| const reason = row.content.reason | ||
| const role = row.content.flags[0] | ||
| const text = `${name} ${action === "remove" ? "removed" : "added"} ${target} as ${role} ${reason ? "reason: " + reason : ''}` | ||
| this.addStatusMessage({ text, timestamp: row.timestamp }) | ||
| next() | ||
| } | ||
| const end = (next) => { next() } | ||
| pump(this.core.moderation.listModerationBy(key), to.obj(write, end)) |
There was a problem hiding this comment.
i might just skip this logic fwiw; what it does is it prints out all moderation actions that occured for all yr mods/admins on first startup of cabal
|
sorry about the wacky indentation, was trying a new thing in vim. looks like all that was being changed in my editor was purely visual; i'll run standard before releasing |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds
/actions- list historic actions by you or your currently applied moderators/roles- shows the admins/mods you have applied atmchat/moderationsee Sort hidden users to bottom of user pane, prefix their names with minus sign cabal-cli#192 for how it is used cc @nikolaiwarner