Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort hidden users to bottom of user pane, prefix their names with minus sign #192

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

cblgh
Copy link
Member

@cblgh cblgh commented Jun 5, 2020

this pr sorts hidden users to the bottom of the user pane (probably dont want someone you've hidden to be in yr face).

their names are also prefixed with a minus sign; eases the amount of mental accounting you need to do to know who is banned & not. see image below for demo

Screen Shot 2020-06-05 at 11 02 57

this PR also greatly improves the styling of applied moderation messages, which are virtual messages with type chat/moderation. see image below

image

@cblgh
Copy link
Member Author

cblgh commented Jun 5, 2020

if you have mod, khajit has bans

@okdistribute
Copy link
Member

okdistribute commented Jun 8, 2020

Can someone change their name to something offensive and still be visible? Is there a way to hide banned users completely? (e.g., why not just remove them completely from the pane?)

@cblgh
Copy link
Member Author

cblgh commented Jun 8, 2020

@okdistribute yes. the reason is it's a bit complex. one thing i was considering was the following:

  • keep the first three letters of the nick, erase the rest and replace with e.g. the first 6 characters of their public key
  • stop propagating/acting on user update events in cabal-client from peers that are hidden if (user.isHidden()) return

so fuckedUpTroll becomes fuc-f8a1b4. this still allows identification in case something went wrong, or people are just trying out moderation actions for the first time (don't wanna hide nickwarner and then be unable to reverse the hide!!)

the moderation messages that are forwarded to others also need to maintain the nickname such that people can know who has been hidden by whom, otherwise the moderation system becomes inscrutable see screenshot below

image

@cblgh
Copy link
Member Author

cblgh commented Jun 8, 2020

tracking yr concerns in this issue here #193 @okdistribute, i'll try to add that in a couple of future PRs and focus on first landing the work i already have in the pipeline :)

@cblgh cblgh merged commit 30332e9 into master Jun 10, 2020
@ghost ghost mentioned this pull request Jun 13, 2020
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants