-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade libraries #5
Comments
Rather upgrade to Spring Boot 1.5.1. Here's what to change: build.gradle
The last line upgrades our Gradle wrapper, see #6. components/cli/cli.gradle
With the lib upgrade, we also need to use the new boot plugin, see #4. components/jclient/jclient.gradle
Using same Gson version as in components/server/server.gradle
The first change set up there is to use the new boot plugin, see #4. The second change set is to upgrade Gson---none of the Boot libs we use depend on it, so we have to add it. (In fact, if you comment out the Gson dep compilation fails on Gson imports.) The third change set is for migrating from HornetQ to Artemis, see #9. components/util/util.gradle
The two changes above is all you need to match the (implicit) version numbers in
|
this commit only changes the source code to make it compile with the new SpringBoot libs.
implemented changes in v1.1.0-beta, see #11. |
We should upgrade to Spring Boot 1.4.3. (We're currently on 1.3.4.)
In
build.gradle
, replacewith
Have a look at the Spring Boot Plugin usage snippet.
This automatically brings in a new Spring dependency set in the server project because we don't specify lib versions except for Gson (=2.4), so we get whatever is in the Spring Boot pom---which is good in general. But the other projects have explicit version numbers---for various reasons. So review the dependencies in these build files:
server.gradle
. See if the new Boot brings in Gson too---it could be one of the libs we depend on now depends on Gson. If that is the case, take action depending on which version Boot brings in. Take into account that jclient uses 2.5. First price would be have the same Gson version across the board if possible.jclient.gradle
. Gson is on 2.5, see point above. As for Http Client, keep the version pinned to 4.3.1 if you want to be able to use in Insight. (See README file.)cli.gradle
. Keep the deps as they are. (See README.)util.gradle
. This is a dependency of server, so you need to match all version numbers to those brought in by Boot. (Technically you don't need to do this for the test deps, but it's best to do it to avoid issues going forward.) NB we can't use Boot dependency management in util as this lib is supposed to be as Spring free as possible! So keep the deps explicit.After you're through with this, all is left to do is...lots of testing!
The text was updated successfully, but these errors were encountered: