refactor(parser): do not parse for links if not needed #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only parse for inline links if a document attribute subsitution occurred also, update the grammar for inline links to parse until the EOF Fixes bytesparadise#462 Signed-off-by: Xavier Coulon <[email protected]>
golangcibot
reviewed
Jan 3, 2020
| @@ -10,102 +10,111 @@ import ( | |||
|
|
|||
| // applyDocumentAttributeSubstitutions(elements applies the document attribute substitutions | |||
| // and re-parse the paragraphs that were affected | |||
| func applyDocumentAttributeSubstitutions(element interface{}, attrs types.DocumentAttributes) (interface{}, error) { | |||
| func applyDocumentAttributeSubstitutions(element interface{}, attrs types.DocumentAttributes) (interface{}, bool, error) { | |||
There was a problem hiding this comment.
cyclomatic complexity 32 of func applyDocumentAttributeSubstitutions is high (> 30) (from gocyclo)
Signed-off-by: Xavier Coulon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 88.56% 88.58% +0.02%
==========================================
Files 63 63
Lines 4057 4066 +9
==========================================
+ Hits 3593 3602 +9
Misses 301 301
Partials 163 163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only parse for inline links if a document attribute
subsitution occurred
also, update the grammar for inline links to parse
until the EOF
Fixes #462
Signed-off-by: Xavier Coulon [email protected]