Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not parse for links if no substitution occurred #462

Closed
xcoulon opened this issue Jan 3, 2020 · 0 comments · Fixed by #463
Closed

Do not parse for links if no substitution occurred #462

xcoulon opened this issue Jan 3, 2020 · 0 comments · Fixed by #463
Assignees
@xcoulon
Labels
area/parser type/refactor
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Jan 3, 2020

In

libasciidoc/pkg/parser/document_processing_apply_substitutions.go

Line 27 in 2a13488

return parseInlineLinks(types.MergeStringElements(elements))
, there is no need to parse the merged {StringElement} to look for links if no document attribute substitution occurred.
@xcoulon xcoulon self-assigned this Jan 3, 2020
@xcoulon xcoulon added this to the v0.3.0 milestone Jan 3, 2020
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 3, 2020
@xcoulon
refactor(parser): do not parse for links if not needed
86819a3 
only parse for inline links if a document attribute
subsitution occurred

also, update the grammar for inline links to parse
until the EOF

Fixes bytesparadise#462

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Jan 3, 2020
Merged
xcoulon added a commit that referenced this issue Jan 3, 2020
@xcoulon
refactor(parser): do not parse for links if not needed (#463)
4b9cc03 
only parse for inline links if a document attribute
substitution occurred

also, update the grammar for inline links to parse
until the EOF

Fixes #462

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/refactor
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

refactor(parser): do not parse for links if not needed xcoulon/libasciidoc
1 participant
@xcoulon