Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underscores break bold formatting #1078

Closed
pjanx opened this issue Aug 24, 2022 · 2 comments · Fixed by #1082
Closed

Underscores break bold formatting #1078

pjanx opened this issue Aug 24, 2022 · 2 comments · Fixed by #1082
Assignees
@xcoulon
Labels
area/parser type/bug
Milestone
v0.8.0

Comments

@pjanx
Copy link
Contributor

pjanx commented Aug 24, 2022 

*a_b* _c_

libasciidoc

<div class="paragraph">
<p>*a_b* <em>c</em></p>
</div>

asciidoctor

<div class="paragraph">
<p><strong>a_b</strong> <em>c</em></p>
</div>

asciidoc

<div class="paragraph"><p><strong>a_b</strong> <em>c</em></p></div>
@xcoulon xcoulon self-assigned this Aug 24, 2022
@xcoulon xcoulon added this to the v0.8.0 milestone Aug 24, 2022
@xcoulon
Copy link
Member

xcoulon commented Aug 24, 2022

thanks for reporting this bug @pjanx, I'll look into it while I'm also working on #1077

@xcoulon xcoulon mentioned this issue Sep 19, 2022
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 19, 2022
@xcoulon
test(parser/renderer): verify quoted text case
3dee7dc 
verifies that `*a_b* _c_` is parsed and renderer as expected
bug itself ws fixed in eecd0bb

Fixes bytesparadise#1078

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Sep 19, 2022
@xcoulon
test(parser/renderer): verify quoted text case (#1082)
0317c63 
verifies that `*a_b* _c_` is parsed and renderer as expected
bug itself ws fixed in eecd0bb

Fixes #1078 

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented Sep 19, 2022

sorry for the late response, @pjanx :/
this bug was fixed in eecd0bb, and I added a couple of tests in #1082 to verify that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/bug
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

test(parser/renderer): verify quoted text case xcoulon/libasciidoc
2 participants
@xcoulon @pjanx