Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Italic formatting confusion within links #1077

Closed
pjanx opened this issue Aug 16, 2022 · 0 comments · Fixed by #1079
Closed

Italic formatting confusion within links #1077

pjanx opened this issue Aug 16, 2022 · 0 comments · Fixed by #1079
Labels
area/parser type/bug
Milestone
v0.8.0

Comments

@pjanx
Copy link
Contributor

pjanx commented Aug 16, 2022 

link:a[__b_c__]

<div class="paragraph">
<p><a href="a"><em>_b_c</em>_</a></p>
</div>

should be

<div class="paragraph">
<p><a href="a"><em>b_c</em></a></p>
</div>
@xcoulon xcoulon added this to the v0.8.0 milestone Aug 17, 2022
@xcoulon xcoulon mentioned this issue Aug 24, 2022
Closed
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 4, 2022
@xcoulon
refactor(parser): simplify QuotedText rules
4529e15 
track last element in a group to compare with its latest character
when needed (ie, to check if a rule can apply or not)

also:
- simplify the `InlineWord` rule
- use `pN` as a class matcher for numbers
- refactor the `Symbol` type

Fixes bytesparadise#1077

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Sep 4, 2022
Merged
xcoulon added a commit that referenced this issue Sep 4, 2022
@xcoulon
refactor(parser): simplify QuotedText rules (#1079)
eecd0bb 
track last element in a group to compare with its latest character
when needed (ie, to check if a rule can apply or not)

also:
- simplify the `InlineWord` rule
- use `\pN` as a class matcher for numbers
- refactor the `Symbol` type

Fixes #1077

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser type/bug
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

refactor(parser): simplify QuotedText rules xcoulon/libasciidoc
2 participants
@xcoulon @pjanx