-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing pooling allocator options as CLI flags (#9256) #9447
Merged
fitzgen
merged 6 commits into
bytecodealliance:main
from
omarjatoi:9256-pooling-allocator-flags
Oct 10, 2024
Merged
Add missing pooling allocator options as CLI flags (#9256) #9447
fitzgen
merged 6 commits into
bytecodealliance:main
from
omarjatoi:9256-pooling-allocator-flags
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarjatoi
commented
Oct 10, 2024
fitzgen
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a couple comments below
omarjatoi
force-pushed
the
9256-pooling-allocator-flags
branch
from
October 10, 2024 19:21
351ba0c
to
eb7bc7b
Compare
also rename `memory_protection_keys` to `pooling_memory_protection_keys`
omarjatoi
force-pushed
the
9256-pooling-allocator-flags
branch
from
October 10, 2024 19:23
eb7bc7b
to
83bb6d8
Compare
Thanks for the comments! I've added defaults in comments and cleaned up the commits. |
fitzgen
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #9256, this PR adds the missing pooling allocator configuration options as CLI flags. I also renamed some minor things for consistency.
PoolingAllocatorConfiguration
to theOptimizeOptions
structpooling-allocator
is enabled and flags are passedpooling_decommit_batch_size
type tousize
memory_protection_keys
topooling_memory_protection_keys