Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose remaining pooling allocator options as CLI flags #9256

Closed
alexcrichton opened this issue Sep 16, 2024 · 6 comments
Closed

Expose remaining pooling allocator options as CLI flags #9256

alexcrichton opened this issue Sep 16, 2024 · 6 comments
Labels
good first issue Issues that are good for new contributors to tackle!

Comments

@alexcrichton
Copy link
Member

Wasmtime's pooling instance allocator has a number of configuration options not all of which are reflected onto the CLI at this time around here. Ideally all of the pooling alloctator configuration options should be reflected on the CLI with a various -O pooling-... flag.
@alexcrichton alexcrichton added the good first issue Issues that are good for new contributors to tackle! label Sep 16, 2024
@alexcrichton
Copy link
Member Author

I'm tagging this as a "good first issue" and the basic task would be:

  1. Write down a list of all configuration options on PoolingAllocationConfig
  2. Write down a list of configuration options that the wasmtime CLI supports configuring
  3. Figure out what's in list (1) and not in list (2)
  4. Add new options for these missing configuration flags along the lines of the items already in list (2)

We don't have exhaustive tests for Wasmtime's CLI options at this time so it's ok to skip the tests for this at this time and just rely on code review to catch issues.

@vHugoObject
Copy link

Can I take this?

@alexcrichton
Copy link
Member Author

Feel free!

@omarjatoi omarjatoi mentioned this issue Oct 10, 2024
Merged
@omarjatoi
Copy link
Contributor

🤦 sorry @vHugoObject! I totally missed your comment before opening the PR.

@vHugoObject
Copy link

vHugoObject commented Oct 10, 2024 via email

github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
@omarjatoi
Add missing pooling allocator options as CLI flags (#9256) (#9447)
f59cad1 
* Update `decommit_batch_size` type to `usize`

* Add missing pooling options to `OptimizeOptions`

* Add new pooling options to configuration

* Add `max_memory_protection_keys` option

also rename `memory_protection_keys` to `pooling_memory_protection_keys`

* Add `total_gc_heaps` option

* Add default options in comments
@alexcrichton
Copy link
Member Author

Landed in #9447, so I'm going to close this. Thkas @omarjatoi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are good for new contributors to tackle!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @vHugoObject @omarjatoi