Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type part of test suite utils #1483

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Type part of test suite utils #1483

merged 1 commit into from
Jun 19, 2024

Conversation

lavigne958
Copy link
Collaborator

closes #1430

@lavigne958 lavigne958 self-assigned this Jun 17, 2024
@lavigne958
Copy link
Collaborator Author

I did not type the whole test suite, too long with no additional benefits.
I typed what is useful for rich editors to help identify test class attributes in order to propose auto-completion with the methods/attributes etc. A bit of coherence in the utils function that generate new spreadsheet names etc.

alifeee
alifeee approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@alifeee alifeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely! this will be helpful :)

@lavigne958 lavigne958 merged commit 5e726a2 into master Jun 19, 2024
10 checks passed
@alifeee alifeee deleted the feature/add_json_type branch June 19, 2024 12:21
@alifeee alifeee mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alifeee alifeee alifeee approved these changes

Assignees

@lavigne958 lavigne958

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing types
2 participants
@lavigne958 @alifeee