-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing types #1430
Comments
ref: #1430 Signed-off-by: Alexandre Lavigne <[email protected]>
ref: #1430 Signed-off-by: Alexandre Lavigne <[email protected]>
ref: #1430 Signed-off-by: Alexandre Lavigne <[email protected]>
add JSON typing using: https://github.com/kevinheavey/jsonalias |
I tried to type the low level HTTP methods using the JSON type provided and it does not work. let's keep the Any for now. we don't have a better solution. I'll type the test so it helps any rich test editor to auto-complete and that would do for now I suppose. |
Overview
Add missing typing in code, all function arguments + return values should be typed.
Details
We found some parts of the code that is not typed, all arguments and all returned values should be typed.
If possible we can try to type the tests too ! it would help while developing tests to have some auto-completion too.
The text was updated successfully, but these errors were encountered: