Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/client export #1392

Merged
merged 4 commits into from
Jan 31, 2024
Merged

bugfix/client export #1392

merged 4 commits into from
Jan 31, 2024

Commits on Jan 29, 2024

  1. fix missing method export in http client

    The `HTTPClient` class was missing the `export` method.
    
    Add it in order for the gspread `Client` and the
    `Spreadsheet` class to use it to export spreadsheets.
    
    closes #1385
    
    Signed-off-by: Alexandre Lavigne <[email protected]>
    lavigne958 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    306ab7a View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Add test to export methods

    Add new test that exports a spreadsheet, using
    the gspread client and the spreadsheet itself.
    
    We serialize our requests into a JSON file.
    JSON cannot serialize binary data (like PDF)
    so we can only test with CSV.
    
    Signed-off-by: Alexandre Lavigne <[email protected]>
    lavigne958 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5b36a4c View commit details
    Browse the repository at this point in the history
  2. Fix missing method in HTTP Client

    Add missing methods to the HTTP client.
    
    update code so the gspread Client and the spreadsheet use
    these new methods in order to:
    - insert
    - list
    - remove
    
    a permission.
    
    We can't test these function automatically as this requires
    exposing personal information in the recorded requests.
    
    We'll add more tests later when we find a way.
    
    closes #1385
    
    Signed-off-by: Alexandre Lavigne <[email protected]>
    lavigne958 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    90fef5f View commit details
    Browse the repository at this point in the history
  3. Fixup pyupgrade linter apply

    Signed-off-by: Alexandre Lavigne <[email protected]>
    lavigne958 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1ea9e40 View commit details
    Browse the repository at this point in the history