bugfix/client export #1392
bugfix/client export #1392
Conversation
The `HTTPClient` class was missing the `export` method. Add it in order for the gspread `Client` and the `Spreadsheet` class to use it to export spreadsheets. closes #1385 Signed-off-by: Alexandre Lavigne <[email protected]>
Add new test that exports a spreadsheet, using the gspread client and the spreadsheet itself. We serialize our requests into a JSON file. JSON cannot serialize binary data (like PDF) so we can only test with CSV. Signed-off-by: Alexandre Lavigne <[email protected]>
Add missing methods to the HTTP client. update code so the gspread Client and the spreadsheet use these new methods in order to: - insert - list - remove a permission. We can't test these function automatically as this requires exposing personal information in the recorded requests. We'll add more tests later when we find a way. closes #1385 Signed-off-by: Alexandre Lavigne <[email protected]>
Signed-off-by: Alexandre Lavigne <[email protected]>
|
nice change :) you are doing a relative lot of PRs, I hope you are having enough time for your sanity :) do we know for sure that these are all the "missing methods"? could there be others? I suppose you have manually checked each Also, I understand this is a "bandage PR" to get people's code working, but, the methods should not be in the |
Ha ha thanks 😉 I do so far so good.
Yes I checked, I noticed we miss some typing in the
I agree, this is temporary, though we might keep it until the next major release (could be much closer than the last one), unless we find a way to move it and keep people's code working (as usual 👀 ) I opened the issue #1399 to discuss it. |
agreed, as mentioned above I created the issue to discuss it. |
my preference would be to make as few major releases as possible, ever. It is not fun to deal with the churn of software |
I think for when we come back to it, you should list which methods you fixed :) |
export()list_permissions()insert_permission()remove_permission()closes #1385