Add saveAsFileBlocking() and saveAsBitmapBlocking() #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be called directly from Java.
This was referenced Jan 30, 2023
| * @param saveSettings builder for multiple save options [SaveSettings] | ||
| */ | ||
| @WorkerThread | ||
| fun saveAsBitmapBlocking(saveSettings: SaveSettings = SaveSettings.Builder().build()): Bitmap |
There was a problem hiding this comment.
You can use @JvmOverload annotation on a single method in Kotlin to make it interop with Java.
There was a problem hiding this comment.
'@jvmoverloads' annotation cannot be used on interface methods
|
I would avoid giving responsibility to the client for handling saving images for java. Rather I will keep the old interface and introduce new |
|
I'm not sure if I understand correctly. There's already coroutine version: |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can be called directly from Java.