Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and CHANGELOG.md #503

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

wasky
Copy link
Contributor

@wasky wasky commented Jan 17, 2023

No description provided.

@wasky wasky marked this pull request as draft January 17, 2023 18:03
@wasky wasky mentioned this pull request Jan 18, 2023
@wasky wasky marked this pull request as ready for review January 29, 2023 10:39
@burhanrashid52
Copy link
Owner

@wasky We Need to update the saving example with the coroutine one. We also need to keep the old one as well.

@wasky
Copy link
Contributor Author

wasky commented Jan 30, 2023

We also need to keep the old one as well.

Is it related to #511 and you want to keep Java support?

@burhanrashid52
Copy link
Owner

burhanrashid52 commented Jan 30, 2023

We also need to keep the old one as well.

Is it related to #511 and you want to keep Java support?

Yes. For documentation purposes.

@wasky
Copy link
Contributor Author

wasky commented Jan 30, 2023

I would introduce new API before the release rather than keep the old one in docs. The reason for this is the exception handling. In current old version of API and in AsyncTask version of API you can't handle potential exceptions from the lib. In new API this will work:

try {
    photoEditor.saveAsFile(...)
} catch(e: Exception) {
    //
}

I made a PR with new API for Java (#512) and changed the README in this PR to show example usage of new API for borh Java and Kotlin.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@burhanrashid52
Copy link
Owner

@wasky I've published the jar. Can you update the documentation?
Also, do you have a Twitter handle?

* Remove info about deprecation of saveAsFile() and saveAsBitmap()
* Update instruction text for coroutines version of saving image
# Conflicts:
#	README.md
@burhanrashid52 burhanrashid52 merged commit 3e7fac7 into burhanrashid52:master Feb 17, 2023
@wasky wasky deleted the changelog branch February 17, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants