Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve issue and pr template. (bunq/sdk_java#56) #57

Merged
merged 7 commits into from
Jan 2, 2018
Merged

Improve issue and pr template. (bunq/sdk_java#56) #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e63799a
Added more information to issue template. (bunq/sdk_java#56)
OGKevin Dec 25, 2017
a413e58
Added pull request template. (bunq/sdk_java#56)
OGKevin Dec 25, 2017
e342f1c
Fixed more typos. (bunq/sdk_java#56)
OGKevin Dec 27, 2017
4976ff3
Point to the correct generated folder. (bunq/sdk_java#56)
OGKevin Dec 27, 2017
80f5981
Added missing period to commit example. (bunq/sdk_java#56)
OGKevin Dec 27, 2017
6a8e694
Replaced should with does. (bunq/sdk_java#56)
OGKevin Dec 27, 2017
03c7227
Better punctuation. (bunq/sdk_java#56)
OGKevin Dec 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/ISSUE_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,17 @@
## What happens:
1.

## Logs
- Logs
## Traceback
[//]: # (If there is a traceback please share it in a quote! You can do this by pasting the traceback text, highlighting it and pressing the quote button.)

## Extra info:
- Tested on
## SDK version and environment
- Tested on [0.12.4](https://github.com/bunq/sdk_java/releases/tag/0.12.4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To save yourself some work, you might want to add a script in the future that automatically updates these numbers to the newest version. (see also youtube-dl as an example).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These version number will be bumped during version bump at during the release phase

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youtube-dl also bumps the version number on a new release, but they have automated it. It's easy to forget one when the numbers appear in more places/examples. No biggy tho for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see what you mean 😁 Will add this to my todo list! 😏

- [ ] Sandbox
- [ ] Production

## Response id
[//]: # (If this error has something to do with a request that fails, please provide the response id of the request.)
- Response id:

## Extra info:
[//]: # (Please provide any other relevant information here)
8 changes: 8 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[//]: # (Thanks for opening this pull request! Before you proceed please make sure that you have an issue that explains what this pull request will do.
Make sure that all your commits link to this issue e.g. "My commit. \(bunq/sdk_java#<issue nr>\)".
If this pull request is changing files that are located in "com.bunq.sdk.model.generated" then this pull request will be closed as these files must/can only be changed on bunq's side.)

## This PR closes/fixes the following issues:
[//]: # (If for some reason your pull request does not require a test case you can just mark this box as checked and explain why it does not require a test case.)
- Closes bunq/sdk_java#
- [ ] Tested