-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve issue and pr template. (bunq/sdk_java#56) #57
Merged
andrederoos
merged 7 commits into
develop
from
feature/bunq/sdk_java#56-improve-issue-and-pr-template
Jan 2, 2018
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e63799a
Added more information to issue template. (bunq/sdk_java#56)
OGKevin a413e58
Added pull request template. (bunq/sdk_java#56)
OGKevin e342f1c
Fixed more typos. (bunq/sdk_java#56)
OGKevin 4976ff3
Point to the correct generated folder. (bunq/sdk_java#56)
OGKevin 80f5981
Added missing period to commit example. (bunq/sdk_java#56)
OGKevin 6a8e694
Replaced should with does. (bunq/sdk_java#56)
OGKevin 03c7227
Better punctuation. (bunq/sdk_java#56)
OGKevin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[//]: # (Thanks for opening this pull request! Before you proceed please make sure that you have an issue that explains what this pull request will do. | ||
Make sure that all your commits link to this issue e.g. "My commit. \(bunq/sdk_java#<issue nr>\)". | ||
If this pull request is changing files that are located in "com.bunq.sdk.model.generated" then this pull request will be closed as these files must/can only be changed on bunq's side.) | ||
|
||
## This PR closes/fixes the following issues: | ||
[//]: # (If for some reason your pull request does not require a test case you can just mark this box as checked and explain why it does not require a test case.) | ||
- Closes bunq/sdk_java# | ||
- [ ] Tested |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To save yourself some work, you might want to add a script in the future that automatically updates these numbers to the newest version. (see also youtube-dl as an example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These version number will be bumped during version bump at during the release phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
youtube-dl also bumps the version number on a new release, but they have automated it. It's easy to forget one when the numbers appear in more places/examples. No biggy tho for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you mean 😁 Will add this to my todo list! 😏