Improve issue and pr template. (bunq/sdk_java#56) #57
Conversation
OGKevin
force-pushed
the
feature/bunq/sdk_java#56-improve-issue-and-pr-template
branch
from
5b1123c
to
a413e58
Compare
|
@sandervdo please 👀 this one. |
.github/ISSUE_TEMPLATE.md
Outdated
| ## Logs | ||
| - Logs | ||
| ## Traceback | ||
| [//]: # (If there is a traceback please share it in a quote! You can do this by pasting the traceback text, then highlight it and press the quote button.) |
There was a problem hiding this comment.
You can do this by pasting the traceback text, then highlight it and press the quote button -> You can do this by pasting the traceback text, highlighting it and pressing the quote button.
| ## Extra info: | ||
| - Tested on | ||
| ## SDK version and environment | ||
| - Tested on [0.12.4](https://github.com/bunq/sdk_java/releases/tag/0.12.4) |
There was a problem hiding this comment.
To save yourself some work, you might want to add a script in the future that automatically updates these numbers to the newest version. (see also youtube-dl as an example).
There was a problem hiding this comment.
These version number will be bumped during version bump at during the release phase
There was a problem hiding this comment.
youtube-dl also bumps the version number on a new release, but they have automated it. It's easy to forget one when the numbers appear in more places/examples. No biggy tho for now.
There was a problem hiding this comment.
Ah I see what you mean 😁 Will add this to my todo list! 😏
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| [//]: # (Thanks for opening this pull request! Before you proceed please make sure that you have an issue that explains what this pull request will do. | |||
| Make sure that all your commits link to this issue e.g. "My commit \(bunq/sdk_java#<issue nr>\)". | |||
There was a problem hiding this comment.
Either make point in regex optional or make sure your example here matches it. 😄
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| If this pull request is changing files that are located in "com.bunq.sdk.model.generated" then this pull request will be closed as these files must/can only be changed on bunq's side.) | ||
|
|
||
| ## This PR closes/fixes the following issues: | ||
| [//]: # (If for some reason your pull request does not require a test case you can just mark this box as checked and explain why it should not require a test case.) |
There was a problem hiding this comment.
why it should not -> why it does not
|
@sandervdo all yours 🐰 |
|
@andrederoos all yours 🌈 |
andrederoos
deleted the
feature/bunq/sdk_java#56-improve-issue-and-pr-template
branch
Closes #56