-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve issue and pr template. (bunq/sdk_java#56) #57
Improve issue and pr template. (bunq/sdk_java#56) #57
Conversation
5b1123c
to
a413e58
Compare
@sandervdo please 👀 this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OGKevin 👻
.github/ISSUE_TEMPLATE.md
Outdated
## Logs | ||
- Logs | ||
## Traceback | ||
[//]: # (If there is a traceback please share it in a quote! You can do this by pasting the traceback text, then highlight it and press the quote button.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do this by pasting the traceback text, then highlight it and press the quote button -> You can do this by pasting the traceback text, highlighting it and pressing the quote button.
## Extra info: | ||
- Tested on | ||
## SDK version and environment | ||
- Tested on [0.12.4](https://github.com/bunq/sdk_java/releases/tag/0.12.4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To save yourself some work, you might want to add a script in the future that automatically updates these numbers to the newest version. (see also youtube-dl as an example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These version number will be bumped during version bump at during the release phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
youtube-dl also bumps the version number on a new release, but they have automated it. It's easy to forget one when the numbers appear in more places/examples. No biggy tho for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you mean 😁 Will add this to my todo list! 😏
.github/PULL_REQUEST_TEMPLATE.md
Outdated
@@ -0,0 +1,8 @@ | |||
[//]: # (Thanks for opening this pull request! Before you proceed please make sure that you have an issue that explains what this pull request will do. | |||
Make sure that all your commits link to this issue e.g. "My commit \(bunq/sdk_java#<issue nr>\)". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either make point in regex optional or make sure your example here matches it. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one 😂
.github/PULL_REQUEST_TEMPLATE.md
Outdated
If this pull request is changing files that are located in "com.bunq.sdk.model.generated" then this pull request will be closed as these files must/can only be changed on bunq's side.) | ||
|
||
## This PR closes/fixes the following issues: | ||
[//]: # (If for some reason your pull request does not require a test case you can just mark this box as checked and explain why it should not require a test case.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it should not -> why it does not
@sandervdo all yours 🐰 |
@andrederoos all yours 🌈 |
Closes #56