-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NovoDataTable): updating data table logic and template to better facilitate custom filters #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct controls (#1374) fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls. Co-authored-by: Kevin Cable <[email protected]>
* fix(): addressing multiple high level security updates * adding back and updating htmlhint dep
… facilitate custom filters
Visit the preview URL for this PR (updated for commit aadae5e): https://novo-elements--pr1382-filterupdates-fb4az43v.web.app (expires Fri, 20 Jan 2023 16:31:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
ndickerson
previously approved these changes
Jan 12, 2023
monroepe
reviewed
Jan 13, 2023
...ments/src/elements/data-table/cell-headers/data-table-header-cell-filter-header.component.ts
Outdated
Show resolved
Hide resolved
monroepe
approved these changes
Jan 13, 2023
ndickerson
approved these changes
Jan 13, 2023
dvoegelin
added a commit
that referenced
this pull request
Feb 2, 2023
* feat(NovoDataTable): updating data table logic and template to better facilitate custom filters (#1382) * fix(NovoButton): disabling enter/space keypresses on disabled/loading buttons (#1375) * fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls (#1374) fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls. Co-authored-by: Kevin Cable <[email protected]> * chore(deps): addressing multiple high level security alerts (#1376) * fix(): addressing multiple high level security updates * adding back and updating htmlhint dep * feat(NovoDataTable): updating data table logic and template to better facilitate custom filters * fix(NovoDataTable): fixing scrollbar issue * fixing typing issue * stricter typing on filter header label Co-authored-by: Vonterio Duncan <[email protected]> Co-authored-by: Kevin Cable <[email protected]> * fix(quickNote): Allow placeholder to hide when clicking in text field to write a note (#1386) Allow placeholder to hide when clicking in text field to write a note --------- Co-authored-by: Vonterio Duncan <[email protected]> Co-authored-by: Kevin Cable <[email protected]> Co-authored-by: EthanMcM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into a few issues when implementing a custom filter in the Bullhorn ATS, so I made some changes to the NovoDataTable and related components to better accommodate custom filters and their styling and functionality.
Verify that...
npm start
andnpm run build
still worksSafari
,Chrome
andFirefox
npm run lint
passesnpm test
passes and code coverage is increasednpm run build
still worksBullhorn Internal Developers
Novo Automation
Screenshots