fix(NovoSelect): Fix issue with hints not displaying within Novo Sele… #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit f3d29a3): https://novo-elements--pr1374-f-fix-dropdown-hints-rny1zbvx.web.app (expires Fri, 09 Dec 2022 15:56:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
monroepe
previously approved these changes
Dec 1, 2022
dvoegelin
force-pushed
the
f/fix-dropdown-hints
branch
from
373d459 to
1f62873
Compare
dvoegelin
approved these changes
Dec 1, 2022
dvoegelin
approved these changes
Dec 2, 2022
monroepe
approved these changes
Dec 2, 2022
dvoegelin
added a commit
that referenced
this pull request
Jan 5, 2023
* fix(NovoButton): disabling enter/space keypresses on disabled/loading buttons (#1375) * fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls (#1374) fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls. Co-authored-by: Kevin Cable <[email protected]> * chore(deps): addressing multiple high level security alerts (#1376) * fix(): addressing multiple high level security updates * adding back and updating htmlhint dep Co-authored-by: Vonterio Duncan <[email protected]> Co-authored-by: Kevin Cable <[email protected]>
dvoegelin
added a commit
that referenced
this pull request
Jan 13, 2023
… facilitate custom filters (#1382) * fix(NovoButton): disabling enter/space keypresses on disabled/loading buttons (#1375) * fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls (#1374) fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls. Co-authored-by: Kevin Cable <[email protected]> * chore(deps): addressing multiple high level security alerts (#1376) * fix(): addressing multiple high level security updates * adding back and updating htmlhint dep * feat(NovoDataTable): updating data table logic and template to better facilitate custom filters * fix(NovoDataTable): fixing scrollbar issue * fixing typing issue * stricter typing on filter header label Co-authored-by: Vonterio Duncan <[email protected]> Co-authored-by: Kevin Cable <[email protected]>
dvoegelin
added a commit
that referenced
this pull request
Feb 2, 2023
* feat(NovoDataTable): updating data table logic and template to better facilitate custom filters (#1382) * fix(NovoButton): disabling enter/space keypresses on disabled/loading buttons (#1375) * fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls (#1374) fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls. Co-authored-by: Kevin Cable <[email protected]> * chore(deps): addressing multiple high level security alerts (#1376) * fix(): addressing multiple high level security updates * adding back and updating htmlhint dep * feat(NovoDataTable): updating data table logic and template to better facilitate custom filters * fix(NovoDataTable): fixing scrollbar issue * fixing typing issue * stricter typing on filter header label Co-authored-by: Vonterio Duncan <[email protected]> Co-authored-by: Kevin Cable <[email protected]> * fix(quickNote): Allow placeholder to hide when clicking in text field to write a note (#1386) Allow placeholder to hide when clicking in text field to write a note --------- Co-authored-by: Vonterio Duncan <[email protected]> Co-authored-by: Kevin Cable <[email protected]> Co-authored-by: EthanMcM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct controls.
Description
Fixes an issue where the hint field on the drop down edit type in field maps does not show
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots