Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Novo 7 upgrade #7

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
7edd03f
Adding IntelliJ file to ignore
johnsully83 Aug 14, 2017
7249469
Merge branch 'upstream' into 'master'
johnsully83 Sep 1, 2017
28aab38
adding AppBridgeService
johnsully83 Sep 1, 2017
57a4126
adding aquarium settings service
johnsully83 Sep 13, 2017
c562b2d
Merge branch 'upstream' into gitlab/upstream
johnsully83 Sep 13, 2017
34ae2fa
Merge branch 'gitlab/upstream'
johnsully83 Sep 13, 2017
4daf716
Merge branch 'master' into feature/settingsService
johnsully83 Sep 13, 2017
dabfeae
Merge branch 'upstream' into gitlab/upstream
johnsully83 Sep 14, 2017
8992a30
Merge branch 'gitlab/upstream'
johnsully83 Sep 14, 2017
236c389
Adding hash routing as well as fixing dep versions
johnsully83 Jan 3, 2018
7923d91
Conflict resolution
johnsully83 Jan 3, 2018
daa2cc1
updating dependencies
Jul 17, 2018
8ed7f90
updating novo elements
Jul 17, 2018
ae14d87
removing lint staged
Jul 17, 2018
951641b
Fixing SSH import
johnsully83 Aug 2, 2018
c6dd91e
Removing annoying lint
johnsully83 Aug 2, 2018
559a819
Added some tools from marlin and adecco-multitenant
johnsully83 Aug 2, 2018
b8e122c
Made some fixes
johnsully83 Aug 2, 2018
63cb468
New tools dealing with tables
johnsully83 Aug 9, 2018
87d655a
Cleanup deps
johnsully83 Aug 9, 2018
d1fd00b
First commit
Sep 8, 2018
dbadc69
Revert "First commit"
Sep 8, 2018
b0fcbff
table-data-provider
johnsully83 Sep 12, 2018
60db8fe
Merge remote-tracking branch 'extension-starter.git/upstream' into HEAD
Sep 12, 2018
a24d9f5
Merge from GitHub
johnsully83 Feb 21, 2019
e30a033
fix
johnsully83 Feb 21, 2019
1f7c8e6
Merge remote-tracking branch 'upstream/master' into upstream
johnsully83 Feb 22, 2019
712e32a
Merge remote-tracking branch 'upstream/master' into upstream
johnsully83 Feb 22, 2019
853b8eb
Merge remote-tracking branch 'upstream/master' into upstream
johnsully83 Feb 22, 2019
56bbcc5
upgrade to novo-elements 6
ribns Apr 25, 2022
9ed4fd6
Update package.json
ribns Apr 28, 2022
bec1c49
Update angular.json
ribns Apr 28, 2022
b466214
updates
ribns May 10, 2022
a95631a
Merge branch 'upgrade-novo-6' into novo-7-upgrade
Jun 17, 2022
499499e
Simplified upgrade to Angular 13 + Novo 7
Jun 17, 2022
dc86883
Update README with Node Version
Jun 17, 2022
8ee3b98
Add basic upgrade documentation to README
Jun 22, 2022
990d887
Rename styleext to style in angular.json
Jun 22, 2022
ce9adf2
fix: deprecate tslint in favor of eslint
Sep 2, 2022
a350171
feat: add @bullhorn/bullhorn-types for typings in new projects.
Sep 2, 2022
fe5a05a
fix: index.html
ribns Sep 10, 2022
79cc1ed
add ckeditor to index.html
ribns Sep 10, 2022
f4e0e9d
ease linting rules and lint the project
ribns Sep 10, 2022
686aa22
add strictTemplates to tsconfig
ribns Sep 10, 2022
a790209
FIx: Adding BrowserAnimationsModule to root module
Jun 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
{
"root": true,
"ignorePatterns": [
"projects/**/*"
],
"overrides": [
{
"files": [
"*.ts"
],
"parserOptions": {
"project": [
"tsconfig.json",
"e2e/tsconfig.json"
],
"createDefaultProgram": true
},
"extends": [
"plugin:@angular-eslint/ng-cli-compat",
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
"plugin:@angular-eslint/template/process-inline-templates"
],
"rules": {
"@angular-eslint/component-selector": [
"warn",
{
"type": "element",
"prefix": "platform",
"style": "kebab-case"
}
],
"@angular-eslint/directive-selector": [
"warn",
{
"type": "attribute",
"prefix": "platform",
"style": "camelCase"
}
],
"@typescript-eslint/naming-convention": [
"warn",
{
"selector": "default",
"format": ["camelCase"]
},
{
"selector": "variable",
"format": ["camelCase", "UPPER_CASE"]
},
{
"selector": "typeLike",
"format": ["PascalCase"]
}
],
"@typescript-eslint/consistent-type-definitions": "error",
"@typescript-eslint/dot-notation": "off",
"@typescript-eslint/explicit-member-accessibility": [
"off",
{
"accessibility": "explicit"
}
],
"@typescript-eslint/no-use-before-define": "error",
"brace-style": [
"error",
"1tbs"
],
"id-blacklist": "off",
"id-match": "off",
"no-trailing-spaces": "off",
"no-underscore-dangle": "off"
}
},
{
"files": [
"*.html"
],
"extends": [
"plugin:@angular-eslint/template/recommended"
],
"rules": {}
}
]
}
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
/node_modules

# IDEs and editors
*.iml
/.idea
.project
.classpath
Expand All @@ -26,6 +27,7 @@
!.vscode/extensions.json

# misc
/.angular/cache
/.sass-cache
/connect.lock
/coverage
Expand Down
19 changes: 14 additions & 5 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
{
"useTabs": false,
"tabWidth": 2,
"singleQuote": true,
"trailingComma": "all",
"useTabs": false,
"semi": true,
"bracketSpacing": true,
"printWidth": 140,
"tabWidth": 2,
"trailingComma": "all",
"arrowParens": "always",
"jsxBracketSameLine": false
}
"endOfLine": "lf",
"overrides": [
{
"files": "*.scss",
"options": {
"singleQuote": false
}
}
]
}
19 changes: 19 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,25 @@

## Getting Started

##### Prerequisites: Node v14.15.x or later

* Clone This
* `npm install` or `yarn install`
* `npm start`


## Upgrade Process

In general, the upgrade process will vary slightly everytime. However, websites such as https://update.angular.io help walk you through the process for each version of Angular. For a concrete example, the entire process of cloning + upgrading from Angular 10 to 13 is detailed below:

1. `git clone x`
2. `npm install`
3. Run `ng update @angular/core@11 @angular/cli@11 --allow-dirty` to take Angular from v10 to v11
4. Run `ng update @angular/core@12 @angular/cli@12 --allow-dirty` to take Angular from v11 to v12
5. Manually update `@angular/cdk` to the Angular 12 version in package.json to fix dependency error
6. `npm install` to install updated `@angular/cdk` and its dependencies
7. `ng update @angular/core@13 @angular/cli@13 --allow-dirty` to take Angular from v12 to v13
8. Update other NPM packages manually in package.json (this was primarily done by looking at packages on https://npmjs.org / text output from `npm install`)
9. `npm install`
10. `ng update novo-elements --migrate-only --from=0.0.0 --to=7.0.0 --force --allow-dirty` to update Novo Elements to v7
11. Manually resolve compile errors (mainly just paths) within Angular app
46 changes: 27 additions & 19 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"allowedCommonJsDependencies": [
"@bullhorn/taurus",
"@bullhorn/dragula",
"brace/mode/javascript",
"angular2-text-mask",
"sha.js",
"date-fns"
],
"outputPath": "dist",
"index": "src/index.html",
"main": "src/main.ts",
Expand All @@ -32,14 +40,20 @@
],
"scripts": [
"node_modules/post-robot/dist/post-robot.min.js"
]
],
"aot": false,
"vendorChunk": true,
"extractLicenses": false,
"buildOptimizer": false,
"sourceMap": true,
"optimization": false,
"namedChunks": true
},
"configurations": {
"prod": {
"optimization": true,
"outputHashing": "all",
"sourceMap": false,
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
Expand Down Expand Up @@ -68,7 +82,8 @@
}
]
}
}
},
"defaultConfiguration": ""
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
Expand Down Expand Up @@ -114,13 +129,12 @@
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"builder": "@angular-eslint/builder:lint",
"options": {
"tsConfig": [
"src/tsconfig.app.json",
"src/tsconfig.spec.json"
],
"exclude": []
"lintFilePatterns": [
"src/**/*.ts",
"src/**/*.html"
]
}
}
}
Expand All @@ -136,15 +150,6 @@
"protractorConfig": "./protractor.conf.js",
"devServerTarget": "platform-extension-starter:serve"
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"e2e/tsconfig.e2e.json"
],
"exclude": []
}
}
}
}
Expand All @@ -153,10 +158,13 @@
"schematics": {
"@schematics/angular:component": {
"prefix": "platform",
"styleext": "scss"
"style": "scss"
},
"@schematics/angular:directive": {
"prefix": "platform"
}
},
"cli": {
"defaultCollection": "@angular-eslint/schematics"
}
}
Loading