-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Novo 7 upgrade #7
base: master
Are you sure you want to change the base?
Conversation
adding AppBridgeService See merge request !1
This reverts commit d1fd00b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a few issues and stopped before I read much further
@@ -48,6 +48,7 @@ export class AppBridgeService { | |||
} | |||
|
|||
private register() { | |||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are we ignoring here? And can this be avoided?
}, | ||
settingsConfig: { | ||
title: 'CustomApp', | ||
authKey: 'Kf6spk2H;FwG#q%hivD]Vf;O2V<8[4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these real authKeys??? :/
}, | ||
settingsConfig: { | ||
title: 'CustomAppInStaging', | ||
authKey: 'UcTw_E_D#Wg]>kVUnK|*~U,Gmhe*{X', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one?
}, | ||
settingsConfig: { | ||
title: 'CustomApp', | ||
authKey: 'UcTw_E_D#Wg]>kVUnK|*~U,Gmhe*{X', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one??
Please review and approve