Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds experimental flagging #576

Merged
merged 5 commits into from
Apr 21, 2020
Merged

Conversation

zmackie
Copy link
Contributor

@zmackie zmackie commented Apr 14, 2020

This global flag should support future development of runtime experimental feature, per the discussion in #368 .

pack report provides an example of how to consume that flag, in addition to reporting it's state:

± zm |feature/experimental → origin S:4 U:1 ✗| → ./out/pack report
Pack:
  Version:  0.0.0+git-27f8c87
  OS/Arch:  darwin/amd64

Default Lifecycle Version:  0.7.2

Config:
  default-builder-image = "heroku/buildpacks:18"
  experimental = true

  [[run-images]]
    image = "cnbs/test"
    mirrors = ["one", "two"]

  [[run-images]]
    image = "cnbs/test2"
    mirrors = ["one", "two"]

@zmackie zmackie requested a review from a team as a code owner April 14, 2020 17:49
cmd/pack/main.go Outdated Show resolved Hide resolved
cmd/pack/main.go Outdated Show resolved Hide resolved
@zmackie zmackie force-pushed the feature/experimental branch 3 times, most recently from a5127da to 0293a8d Compare April 16, 2020 15:55
 - Addresses buildpacks#368

Signed-off-by: Zander Mackie <[email protected]>
@jromero jromero linked an issue Apr 21, 2020 that may be closed by this pull request
@jromero jromero merged commit aca6493 into buildpacks:master Apr 21, 2020
@jromero jromero added this to the 0.11.0 milestone May 19, 2020
@jromero jromero added the type/enhancement Issue that requests a new feature or improvement. label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Feature flags
3 participants