-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the registry flag [-R] behind experimental #608
Comments
Following a discussion with @sclevine, we consider making two changes to the error message:
So the updated error message will be: @jromero, can you please share your opinion? Thanks! |
Minor feedback:
With that in mind, what do you think about this output?
As far as implementation, this should be achievable by creating a custom |
@jromero, thank you for your feedback! Your idea sounds good. |
@jromero After giving it another thought, what do you think about the following solution:
In this way, we won't need to make any changes in the Would love to get your opinion. |
First point makes sense but the second might not work in actuality since you'll want to use the logger to take advantage of it's formatting functions for things such as colors. You could pass the logger to the Error type but I'd be wary of adding logic to a data type. |
Description
The registry is still an early beta. We would like to ensure that users are aware of that. Therefore, we would like that the registry flag
-R
will be visible only if theexperimental
flag is on in the config.Proposed solution
Additional context
The
experimental
flag was introduced in this PR.The
registry
flag was introduced in this PR.The feature should be documented as part of this issue.
The text was updated successfully, but these errors were encountered: