Hide create-package command #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameyer-pivotal
commented
Oct 16, 2019
| @@ -52,6 +52,9 @@ func CreatePackage(logger logging.Logger, client PackClient) *cobra.Command { | |||
| cmd.MarkFlagRequired("package-config") | |||
| cmd.Flags().BoolVar(&flags.Publish, "publish", false, "Publish to registry") | |||
| AddHelpFlag(cmd, "create-package") | |||
|
|
|||
| cmd.Hidden = true | |||
There was a problem hiding this comment.
This will also have the effect of disabling the acceptance tests, since it will no longer show up in the help output. I'm okay with that if everyone else is.
Signed-off-by: Andrew Meyer <[email protected]>
ameyer-pivotal
force-pushed
the
feature/hide-create-package
branch
from
c8c14ec
to
d8cb372
Compare
jromero
approved these changes
Oct 16, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hiding this command as it's not ready for prime-time without additional follow up issues (#240, #347, #348, #349) yet some early adopters might want to play with it.
Signed-off-by: Andrew Meyer [email protected]