Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack create-package validates default ID and version #240

Closed
ekcasey opened this issue Jul 11, 2019 · 1 comment · Fixed by #341
Closed

pack create-package validates default ID and version #240

ekcasey opened this issue Jul 11, 2019 · 1 comment · Fixed by #341
Assignees
@jromero
Labels
type/enhancement Issue that requests a new feature or improvement.

Comments

@ekcasey
Copy link
Member

ekcasey commented Jul 11, 2019

[PLACEHOLDER]

Given a package.toml with the following contents

[default]
id = "id.buildpack.two"
version = "0.0.2"

[[blobs]]
uri = "https://example.com/buildpack1.tgz"

[[stacks]]
id = "some.stack.id"

Where id.buildpack.two is not a buildpack defined in the buildpack.toml in the given blob
Then I receive a helpful error message
@sclevine sclevine changed the title pack create-buildpackage validates default ID and version pack create-package validates default ID and version Jul 12, 2019
@jromero jromero self-assigned this Oct 9, 2019
@jromero jromero added the type/enhancement Issue that requests a new feature or improvement. label Oct 9, 2019
@jromero jromero mentioned this issue Oct 9, 2019
Merged
@jromero jromero added this to the 0.5.0 milestone Oct 11, 2019
@jromero jromero modified the milestones: 0.5.0, 0.6.0 Oct 16, 2019
@ameyer-pivotal ameyer-pivotal mentioned this issue Oct 16, 2019
Merged
@jromero
Copy link
Member

jromero commented Dec 16, 2019

No longer necessary based on changes to package.toml

@jromero jromero removed this from the 0.6.0 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jromero jromero

Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate package creation buildpacks/pack
2 participants
@jromero @ekcasey