Validate buildpack API version #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jromero
force-pushed
the
feature/260-lifecycle-descriptor
branch
from
d92e1c6
to
ef9b4f2
Compare
jromero
force-pushed
the
feature/254-validate-buildpack-api
branch
from
4dda93e
to
06359fa
Compare
jromero
changed the base branch from
feature/260-lifecycle-descriptor
to
master
jromero
force-pushed
the
feature/254-validate-buildpack-api
branch
from
06359fa
to
85c11e8
Compare
jromero
requested review from
djoyahoy and
ekcasey
and removed request for
djoyahoy
ekcasey
requested changes
Sep 9, 2019
* Default lifecycle during `create-builder` if no version or URI is specified Resolves #254 Signed-off-by: Javier Romero <[email protected]> Signed-off-by: Andrew Meyer <[email protected]>
Signed-off-by: Javier Romero <[email protected]>
jromero
force-pushed
the
feature/254-validate-buildpack-api
branch
2 times, most recently
from
bac0a66
to
d0dcd17
Compare
jromero
force-pushed
the
feature/254-validate-buildpack-api
branch
2 times, most recently
from
d915cb0
to
016922c
Compare
ekcasey
approved these changes
Sep 9, 2019
* Fix implementation of `api.Version#SupportsVersion` * Remove AdditionalBuildpack wrapper Signed-off-by: Javier Romero <[email protected]> Signed-off-by: Andrew Meyer <[email protected]>
jromero
force-pushed
the
feature/254-validate-buildpack-api
branch
from
016922c
to
34efdee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
create-builderif no version or URI is specifiedorder.tomlformatResolves #254
Resolves #284
Signed-off-by: Javier Romero [email protected]
Signed-off-by: Andrew Meyer [email protected]