Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the lifecycle's Buildpack API Version to determine order.toml format #284

Closed
jromero opened this issue Sep 6, 2019 · 2 comments · Fixed by #282
Closed

Use the lifecycle's Buildpack API Version to determine order.toml format #284

jromero opened this issue Sep 6, 2019 · 2 comments · Fixed by #282
Assignees
@jromero
Milestone
0.4.0

Comments

@jromero
Copy link
Member

jromero commented Sep 6, 2019

We should use the lifecycle's Buildpack API Version instead of the lifecycle version now.

Originally posted by @ekcasey in https://github.com/buildpack/pack/diffs/53
@jromero jromero mentioned this issue Sep 6, 2019
Merged
@jromero jromero added this to the 0.4.0 milestone Sep 6, 2019
@jromero jromero self-assigned this Sep 6, 2019
jromero added a commit that referenced this issue Sep 6, 2019
@jromero
Resolve #284 - Use BP API Version to determine order.toml format
4841734 
Signed-off-by: Javier Romero <[email protected]>
@jromero jromero mentioned this issue Sep 6, 2019
Merged
jromero added a commit that referenced this issue Sep 9, 2019
@jromero
Resolve #284 - Use BP API Version to determine order.toml format
53c99eb 
Signed-off-by: Javier Romero <[email protected]>
jromero added a commit that referenced this issue Sep 9, 2019
@jromero
Resolve #284 - Use BP API Version to determine order.toml format
1275328 
Signed-off-by: Javier Romero <[email protected]>
@sclevine
Copy link
Member

Seems like we should use the platform API version for order.toml, as it's a contract between the platform and the lifecycle.

@jromero jromero removed the reject label Sep 12, 2019
@jromero
Copy link
Member Author

jromero commented Sep 12, 2019

@sclevine,

As discussed we'll leave this as is although we understand that it makes more sense to be the Platform API. By using the Buildpack API we can still achieve what we need without needing to bump the Platform API for now and in additional it's technically supported by the lifecycle as-is due to our backwards compatibility efforts in lifecycle itself.

@bithavoc bithavoc mentioned this issue Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jromero jromero

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Validate buildpack API version buildpacks/pack
2 participants
@jromero @sclevine