Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH test improvement: use Go SSH server not containerized OpenSSH #1327

Merged
merged 9 commits into from
Nov 29, 2021
Merged

SSH test improvement: use Go SSH server not containerized OpenSSH #1327

merged 9 commits into from
Nov 29, 2021

Conversation

matejvasek
Copy link
Contributor

Resolves #1325

@matejvasek matejvasek requested a review from a team as a code owner November 16, 2021 01:02
@github-actions github-actions bot added this to the 0.23.0 milestone Nov 16, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Nov 16, 2021
@matejvasek matejvasek changed the title SSH test improvement: use Go SSH server not containerized OpenSSH WIP: SSH test improvement: use Go SSH server not containerized OpenSSH Nov 16, 2021
@matejvasek
Copy link
Contributor Author

@aemengo @jromero PTAL

@matejvasek matejvasek changed the title WIP: SSH test improvement: use Go SSH server not containerized OpenSSH SSH test improvement: use Go SSH server not containerized OpenSSH Nov 16, 2021
@dfreilich dfreilich added type/chore Issue that requests non-user facing changes. and removed type/enhancement Issue that requests a new feature or improvement. labels Nov 16, 2021
@aemengo
Copy link
Contributor

aemengo commented Nov 17, 2021

@matejvasek Please consider the following PR: matejvasek/pack/pull/44, which makes some amendments to ssh_dialer_test.go, to make it consistent with the rest of pack's spec.

It would also address: #1319

@matejvasek
ssh_dialer_test.go edits
45ab00a 
* Use sclevine/spec test reporter
* Use testhelpers for err == nil checks

Signed-off-by: Anthony Emengo <[email protected]>
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. and removed type/chore Issue that requests non-user facing changes. labels Nov 17, 2021
@matejvasek
Copy link
Contributor Author

@aemengo do you have any idea why the two windows test failed? Is it just a flake?

@jromero
Copy link
Member

jromero commented Nov 17, 2021

@matejvasek just reran those. Appear like there was a temporary outage with codecov. All good now.

@matejvasek
cleanup
3505c25 
Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
cleanup
cfc1c81 
Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
Better close() handling
00950c6 
Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
fix: dataraces
66a07f9 
Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
fixup: style
7792e62 
Signed-off-by: Matej Vasek <[email protected]>
dfreilich
dfreilich approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfreilich dfreilich merged commit ba8b47a into buildpacks:main Nov 29, 2021
@aemengo aemengo mentioned this pull request Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aemengo aemengo aemengo approved these changes

@dfreilich dfreilich dfreilich approved these changes

Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

ssh_dialer_test.go should use mock Go SSH server instead of container
4 participants
@matejvasek @aemengo @jromero @dfreilich