Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_dialer_test.go should use mock Go SSH server instead of container #1325

Closed
matejvasek opened this issue Nov 15, 2021 · 0 comments · Fixed by #1327
Closed

ssh_dialer_test.go should use mock Go SSH server instead of container #1325

matejvasek opened this issue Nov 15, 2021 · 0 comments · Fixed by #1327
Labels
status/triage Issue or PR that requires contributor attention. type/chore Issue that requests non-user facing changes.

Comments

@matejvasek
Copy link
Contributor

Description

The test right now requires Linux Containerization so test cannot be run on macOS.
It could run on Windows with Windows' containerization but that would require adding new Windows docker file,
and probably some more Windows specific code.

Proposed solution

Replace containerized SSH testing server with SSH server in Go.

This would be also useful for porting the code back to podman.

Additional context

See https://github.com/knative-sandbox/kn-plugin-func/blob/main/docker/docker_client_ssh_test.go#L62

@matejvasek matejvasek added status/triage Issue or PR that requires contributor attention. type/chore Issue that requests non-user facing changes. labels Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage Issue or PR that requires contributor attention. type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant