Pass mountPaths.appDirName to lifecycle as -app arg #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Kutner <[email protected]>
github-actions
bot
added
the
type/enhancement
Signed-off-by: Joe Kutner <[email protected]>
dfreilich
reviewed
Apr 28, 2021
| @@ -193,7 +193,7 @@ func (l *LifecycleExecution) Create(ctx context.Context, publish bool, dockerHos | |||
|
|
|||
| opts := []PhaseConfigProviderOperation{ | |||
| WithFlags(l.withLogLevel(flags...)...), | |||
| WithArgs(repoName), | |||
| WithArgs("-app", l.mountPaths.appDirName(), repoName), | |||
There was a problem hiding this comment.
Does lifecycle expect it in the format \appdir, or in c:\appdir? If the later, we can use mountPaths.appDir() instead
There was a problem hiding this comment.
oh, i might need to revert 51887a3 in favor of using mountPaths.appDir()
Signed-off-by: Joe Kutner <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 136 136
Lines 8299 8299
=======================================
Hits 6705 6705
Misses 1164 1164
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Closing this in favor of #1149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fast follow fix for #1141
Output
Before
app dir was mounted, but lifecycle was not
cd-ing into it.After
The provide workspace becomes the
CNB_APP_DIRDocumentation