-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added workspace mount point as option to build #1141
Conversation
Signed-off-by: Joe Kutner <[email protected]>
b23f2d3
to
66d3c41
Compare
Codecov Report
@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 80.77% 80.80% +0.03%
==========================================
Files 136 136
Lines 8289 8299 +10
==========================================
+ Hits 6695 6705 +10
Misses 1164 1164
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more. |
@jkutner Hey thanks for the PR, any chance we could get some associated testing here at whatever level you're comfortable with? Codecov seems a little suspect 🤨 |
Signed-off-by: Joe Kutner <[email protected]>
Signed-off-by: Joe Kutner <[email protected]>
@dwillist done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Happy to see this driven out, given the recent feedback on it. If you could just change the assertions in the test a bit to more accurately test the change, that would be 🤯
… workspace flag Signed-off-by: David Freilich <[email protected]>
Summary
Allow the
workspace
directory to be configurable.Output
Before
After
Documentation
Related
Resolves #1121