Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Platform APIs 0.5, 0.6 #1051

Merged
merged 9 commits into from
Jun 15, 2021
Merged

Support Platform APIs 0.5, 0.6 #1051

merged 9 commits into from
Jun 15, 2021

Conversation

dwillist
Copy link
Contributor

@dwillist dwillist commented Feb 2, 2021

Summary

implement changes needed to support platform api 0.6, Need to wait for a lifecycle release with buildpacks/lifecycle#520 to be merged and released before writing acceptance tests.

Really this PR just makes the following changes in the codebase:

  • Remove process type defaults for platform API 0.6

@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Feb 2, 2021
@github-actions github-actions bot added this to the 0.17.0 milestone Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #1051 (acbc306) into main (e53adb9) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   80.52%   80.97%   +0.46%     
==========================================
  Files         136      136              
  Lines        6050     8306    +2256     
==========================================
+ Hits         4871     6725    +1854     
- Misses        751     1156     +405     
+ Partials      428      425       -3     
Flag Coverage Δ
os_linux 80.57% <100.00%> (+0.06%) ⬆️
os_macos 78.04% <83.34%> (?)
os_windows 80.89% <100.00%> (?)
unit 80.57% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dfreilich dfreilich modified the milestones: 0.17.0, 0.18.0 Feb 3, 2021
@dwillist dwillist changed the title Platform api 0 6 Platform api 0.6 Feb 3, 2021
@dfreilich dfreilich changed the title Platform api 0.6 Support Platform API 0.6 Feb 8, 2021
@dfreilich dfreilich added status/blocked Issue or PR that is blocked. See comments. and removed type/chore Issue that requests non-user facing changes. labels Feb 8, 2021
@dfreilich
Copy link
Member

If there isn't expected to be a lifecycle update with buildpacks/lifecycle#520, should we defer this to the next milestone?

@dwillist
Copy link
Contributor Author

@dfreilich sounds good 👍

@jromero jromero modified the milestones: 0.18.0, 0.19.0 Mar 22, 2021
@dfreilich
Copy link
Member

Given the release of lifecycle v0.11.1 with the required change, this probably can be undrafted. @dwillist Is there any additional work that needs to be done to bring it up to spec, or should we start reviewing it?

@dfreilich dfreilich marked this pull request as ready for review April 5, 2021 18:54
@dfreilich dfreilich requested a review from a team as a code owner April 5, 2021 18:54
@dfreilich dfreilich removed the status/blocked Issue or PR that is blocked. See comments. label Apr 18, 2021
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Apr 27, 2021
@dwillist dwillist self-assigned this May 3, 2021
@dwillist dwillist changed the title Support Platform API 0.6 Remove Process Type Defaults for Platform API 0.6 May 14, 2021
@dwillist dwillist changed the title Remove Process Type Defaults for Platform API 0.6 Support Platform APIs 0.5, 0.6 Jun 2, 2021
@jromero
Copy link
Member

jromero commented Jun 11, 2021

Ping @dwillist 👋 Is this really ready to merge out are there any outstanding items?

@aemengo
Copy link
Contributor

aemengo commented Jun 12, 2021

@jromero

Is this really ready to merge […]

The conversation happened out of band, but word was it’s “just waiting for reviews”

Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great!

Quite a few of the changes were in adding a space before a comment, so there were fewer changes than I expected, and I'm sorry we didn't merge it in earlier!

@dfreilich dfreilich modified the milestones: 0.19.0, 0.20.0 Jun 15, 2021
@dfreilich dfreilich merged commit 8d369e5 into main Jun 15, 2021
@dfreilich dfreilich deleted the platform_api_0_6 branch June 15, 2021 18:16
@hone hone linked an issue Jun 23, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support Platform API 0.5 & 0.6
4 participants