Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack should stop providing default process type web by default to the lifecycle #946

Closed
jromero opened this issue Nov 10, 2020 · 1 comment
Closed

Pack should stop providing default process type web by default to the lifecycle #946

jromero opened this issue Nov 10, 2020 · 1 comment
Labels
type/enhancement Issue that requests a new feature or improvement.

Comments

@jromero
Copy link
Member

jromero commented Nov 10, 2020

Description

As per buildpacks/rfcs#110, beginning Platform API 0.X (TBD) pack should no longer pass -process-type unless the user provides given value.

pack stops sending -process-type web when CNB_PLATFORM_API is greater than 0.X. The lifecycle will assume default = true for web processes from buildpacks implementing buildpack APIs earlier than 0.Y. The lifecycle could print an info message when buildpacks do not specify a default process type. -process-type could then become a failure case (vs. warn, what it is today).
@jromero jromero added type/enhancement Issue that requests a new feature or improvement. status/blocked Issue or PR that is blocked. See comments. labels Nov 10, 2020
@wburningham wburningham mentioned this issue Feb 23, 2021
Closed
@sambhav
Copy link
Member

sambhav commented Apr 6, 2021

#1051 should fix this?

@dwillist dwillist added platform-api/0.6 and removed status/blocked Issue or PR that is blocked. See comments. labels May 14, 2021
@jromero jromero closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jromero @sambhav @dwillist