Enclose all variables in the linux userdata in quotes #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents word splitting or globbing. See shellcheck error SC2046 for details on the error: https://github.com/koalaman/shellcheck/wiki/SC2046
|
Thanks for opening these pull requests @twunderlich-grapl and @christophermaier, I’m sorry you ran into this issue and appreciate your submitting the fix 🙇 I’ll merge this now which will make it available in the template built from the |
|
Thank you @keithduncan for the super-fast response 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encloses all variables in the linux userdata script with quotes to prevent word splitting or globbing. Currently if a string with a space is submitted to one of the unquoted variables, the script breaks.
See shellcheck error SC2046 for details on this type of error and ways to fix it.