Quote additional sudo permissions #915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands specified in a sudoers file can be simple commands, or they can be commands and arguments. Thus, `BUILDKITE_ADDITIONAL_SUDO_PERMISSIONS` can be expected to contain spaces, and should be quoted. Without quotes, anything after the space is taken to be a separate command to be invoked, which will often give you a non-functional instance (at least as far as interacting with Buildkite is concerned). A workaround is to manually escape any spaces. Signed-off-by: Christopher Maier <[email protected]>
|
Withdrawing in favor of my coworker's patch in #916 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands specified in a sudoers file can be simple commands, or they
can be commands and arguments. Thus,
BUILDKITE_ADDITIONAL_SUDO_PERMISSIONScan be expected to containspaces, and should be quoted.
Without quotes, anything after the space is taken to be a separate
command to be invoked, which will often give you a non-functional
instance (at least as far as interacting with Buildkite is concerned).
A workaround is to manually escape any spaces.
Signed-off-by: Christopher Maier [email protected]