Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: pin awscli to v1; v2 breaks 'aws ecr get-login' #670

Merged
merged 2 commits into from
Mar 3, 2020
Merged

windows: pin awscli to v1; v2 breaks 'aws ecr get-login' #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
541c1cf
Remove 'shellcheck disable=SC1117'; no longer required.
pda Mar 3, 2020
7aa387a
windows: pin awscli to v1; v2 breaks 'aws ecr get-login'
pda Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .buildkite/steps/launch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/bin/bash
# shellcheck disable=SC1117
set -eu

os="${1:-linux}"
Expand Down
4 changes: 3 additions & 1 deletion packer/windows/scripts/install-utils.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ Set-ExecutionPolicy Bypass -Scope Process -Force
Invoke-Expression ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))

Write-Output "Installing awscli"
choco install -y awscli
# pinned because awscli v2 drops 'aws ecr get-login'
# https://github.com/buildkite-plugins/ecr-buildkite-plugin/issues/37
choco install -y awscli --version=1.18.11
If ($lastexitcode -ne 0) { Exit $lastexitcode }

Write-Output "Installing Git for Windows"
Expand Down