windows: pin awscli to v1; v2 breaks 'aws ecr get-login' #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be unpinned after ecr-buildkite-plugin adds support for awscli v2. See: buildkite-plugins/ecr-buildkite-plugin#37
|
should we backport this to |
|
oh wait, there's no windows support in |
|
Should be able to unpin now that buildkite-plugins/ecr-buildkite-plugin#40 is available? |
|
I think we're intentionally keeping awscli v1 for the upcoming v5.0.0 release, to avoid adding another breaking change into a release that's been baking for so long. We hope to bump to v2 after the v5 release though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows AMI pinned to awscli v1
See buildkite-plugins/ecr-buildkite-plugin#37
This patch pins
choco install awsclito the currently-latest1.18.11; see https://chocolatey.org/packages/awscli/1.18.11#versionhistory (Chocolatey doesn't make it possible to pin to a major version.)This should be reverted after the ECR plugin supports awscli v2.