Revert "Revert "Move toolchain registration into WORKSPACE (#5070)"" #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
changed the title
bduffany
approved these changes
Oct 23, 2023
This reverts commit 1647371. We previously introduced this in 5070 but reverted due to incompatibilities with internal repo. Will couple this PR with another internal PR to ensure compatibility between the 2.
sluongng
force-pushed
the
sluongng/revert-revert-5070
branch
from
2d688dd to
0021720
Compare
sluongng
added a commit
that referenced
this pull request
Oct 30, 2023
We have removed target-linux in #5088 in favor of `--config=remote` working out of the box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1647371.
We previously introduced this in 5070 but reverted due to
incompatibilities with internal repo. Will couple this PR with another
internal PR to ensure compatibility between the 2.