Move toolchain registration into WORKSPACE #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/toolchain-registration
branch
from
33b3d1e to
47314dd
Compare
sluongng
changed the title
sluongng
force-pushed
the
sluongng/toolchain-registration
branch
from
47314dd to
19a0c99
Compare
Register our toolchains inside WORKSPACE. Then enable automatic cc toolchain resolution for auto selection based on platform compatibility.
sluongng
force-pushed
the
sluongng/toolchain-registration
branch
from
19a0c99 to
cd4e52f
Compare
|
The expected outcome here is from a MacOS laptop, you should be able to just do |
siggisim
approved these changes
Oct 20, 2023
sluongng
added a commit
that referenced
this pull request
Oct 23, 2023
This reverts commit 8073210. Need to update internal repo before re-merging this PR
sluongng
added a commit
that referenced
this pull request
Oct 23, 2023
sluongng
added a commit
that referenced
this pull request
Oct 23, 2023
This reverts commit 1647371. We previously introduced this in 5070 but reverted due to incompatibilities with internal repo. Will couple this PR with another internal PR to ensure compatibility between the 2.
sluongng
added a commit
that referenced
this pull request
Oct 27, 2023
This reverts commit 1647371. We previously introduced this in 5070 but reverted due to incompatibilities with internal repo. Will couple this PR with another internal PR to ensure compatibility between the 2.
sluongng
added a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register our toolchains inside WORKSPACE.
Then enable automatic cc toolchain resolution for auto selection based
on platform compatibility.
This let us get rid of the manual toolchain declaration when building with
--config=remote. Subsequently, we won't need to specify--cpuand--host_cputo aid cc_toolchain_suite detection.