Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove app engine code and references #109

Merged
merged 2 commits into from
Mar 25, 2019
Merged

remove app engine code and references #109

merged 2 commits into from
Mar 25, 2019

Conversation

kellymason
Copy link
Contributor

@kellymason kellymason commented Mar 25, 2019

Goal

Removes support for the old version of Google App Engine that Google has now dropped.

Design

All references to google app engine and related code should be removed.

Removed

  • appengine.go
  • appengine-test.go
  • app engine example app
  • documentation references

Tests

I ran go test and received the following issues, but if I understand correctly this is a known issue:

    bugsnag_test.go:627: Expected frame file to be 'runtime/panic.go' but was 'runtime/chan.go'
    bugsnag_test.go:630: Expected frame method to be 'gopanic' but was 'chansend'
    bugsnag_test.go:627: Expected frame file to be 'bugsnag_test.go' but was 'net/http/server.go'
    bugsnag_test.go:630: Expected frame method to be 'crashyHandler' but was 'HandlerFunc.ServeHTTP'
    bugsnag_test.go:638: Expected frame inProject to be 'true' but was 'false'
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • [ x ] Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@kellymason kellymason requested a review from kinbiko March 25, 2019 10:05
@kinbiko
Copy link
Contributor

kinbiko commented Mar 25, 2019

@kellymason The test failures you saw are new in Go 1.12 (latest version), and have been fixed in #105. Presumably, these only appear locally.

Copy link
Contributor

@kinbiko kinbiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bengourley bengourley merged commit 8cebe7c into next Mar 25, 2019
@bengourley bengourley deleted the remove-app-engine branch March 25, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants