Skip to content

Commit

Permalink
Merge pull request #109 from bugsnag/remove-app-engine
Browse files Browse the repository at this point in the history
remove app engine code and references
  • Loading branch information
bengourley authored Mar 25, 2019
2 parents 2410940 + cb28374 commit 8cebe7c
Show file tree
Hide file tree
Showing 14 changed files with 2 additions and 180 deletions.
11 changes: 0 additions & 11 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ Installing the go development environment
export PATH=$PATH:$GOPATH/bin
```
Installing the appengine development environment
------------------------------------------------
1. Follow the [Google instructions](https://cloud.google.com/appengine/downloads).
Downloading the code
--------------------
Expand All @@ -58,12 +53,6 @@ You can run the tests with
go test
```

If you've made significant changes, please also test the appengine integration with

```shell
goapp test
```

Releasing a New Version
-----------------------

Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ Learn more about Bugsnag's [Go error monitoring and error reporting](https://www

1. [Create a Bugsnag account](https://bugsnag.com)
2. Complete the instructions in the integration guide for your framework:
* [Google App Engine](https://docs.bugsnag.com/platforms/go/app-engine/)
* [Martini](https://docs.bugsnag.com/platforms/go/martini)
* [Negroni](https://docs.bugsnag.com/platforms/go/negroni)
* [net/http](https://docs.bugsnag.com/platforms/go/net-http)
Expand All @@ -29,7 +28,6 @@ Learn more about Bugsnag's [Go error monitoring and error reporting](https://www
## Support

* Read the configuration reference:
* [Google App Engine](https://docs.bugsnag.com/platforms/go/app-engine/configuration-options/)
* [Martini](https://docs.bugsnag.com/platforms/go/martini/configuration-options/)
* [Negroni](https://docs.bugsnag.com/platforms/go/negroni/configuration-options/)
* [net/http](https://docs.bugsnag.com/platforms/go/net-http/configuration-options/)
Expand Down
81 changes: 0 additions & 81 deletions appengine.go

This file was deleted.

21 changes: 0 additions & 21 deletions appengine_test.go

This file was deleted.

1 change: 0 additions & 1 deletion bugsnag.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ func init() {
ReleaseStage: "",
ParamsFilters: []string{"password", "secret", "authorization", "cookie"},
SourceRoot: sourceRoot,
// * for app-engine
ProjectPackages: []string{"main*"},
NotifyReleaseStages: nil,
Logger: log.New(os.Stdout, log.Prefix(), log.Flags()),
Expand Down
2 changes: 1 addition & 1 deletion configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ type Configuration struct {
Printf(format string, v ...interface{}) // limited to the functions used
}
// The http Transport to use, defaults to the default http Transport. This
// can be configured if you are in an environment like Google App Engine
// can be configured if you are in an environment
// that has stringent conditions on making http requests.
Transport http.RoundTripper
// Whether bugsnag should notify synchronously. This defaults to false which
Expand Down
2 changes: 1 addition & 1 deletion doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ when you call ListenAndServer:
http.ListenAndServe(":8080", bugsnag.Handler(nil))
If that's not possible, for example because you're using Google App Engine, you can also wrap each
If that's not possible, you can also wrap each
HTTP handler manually:
http.HandleFunc("/" bugsnag.HandlerFunc(func (w http.ResponseWriter, r *http.Request) {
Expand Down
1 change: 0 additions & 1 deletion examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,3 @@ The examples that expose a HTTP port will all listen on 9001.
* [Using Negroni](negroni) (web framework)
* [Using Martini](martini) (web framework)
* [Using Revel](revelapp) (web framework)
* [Deploying to Google App Engine](appengine)
14 changes: 0 additions & 14 deletions examples/appengine/README.md

This file was deleted.

8 changes: 0 additions & 8 deletions examples/appengine/app.yaml

This file was deleted.

31 changes: 0 additions & 31 deletions examples/appengine/hello.go

This file was deleted.

4 changes: 0 additions & 4 deletions examples/appengine/mylogs.txt

This file was deleted.

2 changes: 0 additions & 2 deletions panicwrap.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build !appengine

package bugsnag

import (
Expand Down
2 changes: 0 additions & 2 deletions panicwrap_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// +build !appengine

package bugsnag

import (
Expand Down

0 comments on commit 8cebe7c

Please sign in to comment.