Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that large breadcrumbs are no longer dropped #698

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Verifies that breadcrumbs with a serialized size > 4kb are not dropped when added to the Client. This behaviour changed in #433.

@fractalwrench fractalwrench requested review from twometresteve and removed request for Cawllec June 11, 2020 15:24
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 6bb6549 into v6 Jun 12, 2020
@fractalwrench fractalwrench deleted the v6-breadcrumb-size branch June 12, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants