Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename breadcrumb 'name' to 'message' removing length limit #433

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Rename breadcrumb 'name' to 'message' removing length limit #433

merged 1 commit into from
Feb 20, 2020

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented Nov 5, 2019 •
edited
Loading

Goal

  1. Rename 'name' to 'message'
  2. Remove 4kb length limit on individual breadcrumbs

@bugsnag bugsnag deleted a comment from fractalwrench Feb 19, 2020
@kattrali kattrali changed the base branch from master to spec-compliance February 19, 2020 12:43
@kattrali kattrali changed the title Drop crumb metadata to save breadcrumbs Rename breadcrumb 'name' to 'message' removing length limit Feb 19, 2020
@kattrali
feat(crumbs): Allow arbitrarily long names
05e6cec 
This is necessary before dropping metadata because breadcrumbs left via
Bugsnag.leaveBreadcrumb(message) would no longer be able to be
differentiated as all would have type = manual and name = manual.
robinmacharg
robinmacharg approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@robinmacharg robinmacharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor linguistic nit, but approved on the assumption you'll apply best judgement.

@kattrali kattrali merged commit a9a119b into spec-compliance Feb 20, 2020
@kattrali kattrali deleted the kattrali/drop-crumb-metadata branch February 20, 2020 12:55
@fractalwrench fractalwrench mentioned this pull request Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinmacharg robinmacharg robinmacharg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattrali @robinmacharg