-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use depth in stacktrace length calc #363
Conversation
Per some in-person discussion, PR is ready pending:
|
…elegate for testing
…cases that need to load KSCrashReport
update report test file to handled error of severity info
as we suspect they were incorrect before
Mangled swift is unstable and differs a lot between versions
51de3fc
to
0f73076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small change in 0f73076 to test against the demangled Swift method name rather than the mangled one for both ease of readability and to reduce breakage later. Testing the mangled name failed for me locally because it was different by a single letter.
Looks good, next time let's get the changeset smaller by splitting up the tangentially related changes into separate PRs (renaming files, etc)
Goal
Fixes #357
Design
Use top level dictionary to store depth
Changeset
Extracted report tests into a separate file
Tests
Unit test
Updated test expectations as per @kattrali comment:
#359 (comment)
Review
Outstanding Questions
master
for fixes,next
forfeatures)