Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth #359

Closed
wants to merge 9 commits into from
Closed

Fix depth #359

wants to merge 9 commits into from

Conversation

paulz
Copy link
Contributor

@paulz paulz commented Jun 7, 2019

Goal

Fixes #357

Design

Use top level dictionary to store depth

Changeset

Extracted report tests into a separate file

Tests

Unit test
Load report test

Mazerunner tests are failing and probably need update, please help, @kattrali

Review

Outstanding Questions

  • Added a changelog entry? Not yet
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@kattrali
Copy link
Contributor

kattrali commented Jun 7, 2019

The test failures on CI look like they need the test assertions to be updated. The tests are verifying the length of the stacktrace which is directly affected by changes to depth.

@paulz paulz mentioned this pull request Jun 11, 2019
12 tasks
@kattrali
Copy link
Contributor

Closing in favor of #363

@kattrali kattrali closed this Jun 11, 2019
@paulz paulz deleted the fix-depth branch June 17, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjusting report depth for handled errors has no effect
2 participants