Fix deserialization bug in persisted NDK errors #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
fix-app-struct-migration
branch
from
b814b1d
to
71f43d7
Compare
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
Apr 13, 2021
fractalwrench
force-pushed
the
fix-app-struct-migration
branch
from
71f43d7
to
14eb6ee
Compare
|
Tweaked release date to TBD. |
fractalwrench
added a commit
that referenced
this pull request
Apr 15, 2021
Fix deserialization bug in persisted NDK errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The memory offset for
bsg_app_info_v2is wrong by one due to the unintentional inclusion ofis_launching. This means that the first byte ofbinary_archfor persisted v4 structs is loaded intois_launching, causing thebinary_archto be incorrectly trimmed to '86' or 'rm64'.Changeset
Removed
is_launchingfrombsg_app_info_v2as it was not originally present.Testing
Added additional unit test coverage of the migration function. Manually tested by triggering a fatal crash in v5.7.0, then updating to v5.9.0 to reproduce the behaviour. Confirmed that a local artefact with these changes fixed the issue.